[Marble-devel] Review Request: Interface for Small Screen Devices
Siddharth Srivastava
akssps011 at gmail.com
Sun Aug 15 20:41:27 CEST 2010
> On 2010-08-13 20:41:22, Dennis Nienhüser wrote:
> > /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.h, line 71
> > <http://reviewboard.kde.org/r/5011/diff/1/?file=33739#file33739line71>
> >
> > I'd rather have
> >
> > void positionProviderPluginChanged( PositionProviderPlugin* activePlugin )
> >
> > which would be emitted by setPositionProviderPlugin(). "Disabled" would result in
> > emit positionProviderPluginChanged( 0 );
> >
> > This avoids the redundant method.
> >
done
> On 2010-08-13 20:41:22, Dennis Nienhüser wrote:
> > /trunk/KDE/kdeedu/marble/src/lib/graphicsview/WidgetGraphicsItem.h, line 28
> > <http://reviewboard.kde.org/r/5011/diff/1/?file=33742#file33742line28>
> >
> > Can you explain this change?
removed. Added a few weeks ago with some experimental stuff :-)
> On 2010-08-13 20:41:22, Dennis Nienhüser wrote:
> > /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingModel.cpp, line 400
> > <http://reviewboard.kde.org/r/5011/diff/1/?file=33749#file33749line400>
> >
> > Don't use c-style casts, please.
> >
> > qint64 value = (qint64) something;
> >
> > can be replaced with ctor-like casts:
> >
> > qint64 value = qint64( something );
> >
> > Then there's also qRound.
thanks..
> On 2010-08-13 20:41:22, Dennis Nienhüser wrote:
> > /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.h, line 56
> > <http://reviewboard.kde.org/r/5011/diff/1/?file=33756#file33756line56>
> >
> > Doesn't this enum duplicate another one?
yes, similar to in AdjustNavigation
> On 2010-08-13 20:41:22, Dennis Nienhüser wrote:
> > /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.h, line 167
> > <http://reviewboard.kde.org/r/5011/diff/1/?file=33756#file33756line167>
> >
> > setXY without a parameter sounds odd. Maybe rename the method.
changed to updateRoutingItem()
> On 2010-08-13 20:41:22, Dennis Nienhüser wrote:
> > /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.cpp, line 498
> > <http://reviewboard.kde.org/r/5011/diff/1/?file=33757#file33757line498>
> >
> > isEmpty()?
oh..yes. Done
- Siddharth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5011/#review7042
-----------------------------------------------------------
On 2010-08-15 18:34:41, Siddharth Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5011/
> -----------------------------------------------------------
>
> (Updated 2010-08-15 18:34:41)
>
>
> Review request for marble and Dennis Nienhüser.
>
>
> Summary
> -------
>
> An interface of Routing Plugin for Small Screen Devices is added. The Routing Plugin for Small Screen Device contains options for navigation( recenter, auto zoom), routing information widget, zoom in and zoom out functionalities.
> The routing information widget for desktop version of marble, now shows the next instruction as well as the distance remaining to reach it.
>
> The instruction point now grows in two levels when the gps location gets closer to it instead of displaying the instruction text at it. 1) The instruction point going to be visited grows in size 2) When the gps device is at certain time away from the instruction point, it grows a bit further.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.h 1164052
> /trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.cpp 1164052
> /trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.ui 1164052
> /trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.h 1164052
> /trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.cpp 1164052
> /trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.cpp 1164052
> /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1164052
> /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1164052
> /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.h 1164052
> /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp 1164052
> /trunk/KDE/kdeedu/marble/src/lib/graphicsview/ScreenGraphicsItem_p.h 1164052
> /trunk/KDE/kdeedu/marble/src/lib/graphicsview/WidgetGraphicsItem.h 1164052
> /trunk/KDE/kdeedu/marble/src/lib/routing/AdjustNavigation.h 1164052
> /trunk/KDE/kdeedu/marble/src/lib/routing/AdjustNavigation.cpp 1164052
> /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingLayer.cpp 1164052
> /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.h 1164052
> /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.cpp 1164052
> /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingModel.h 1164052
> /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingModel.cpp 1164052
> /trunk/KDE/kdeedu/marble/src/marble.qrc 1164052
> /trunk/KDE/kdeedu/marble/src/plugins/render/navigation/NavigationFloatItem.h 1164052
> /trunk/KDE/kdeedu/marble/src/plugins/render/navigation/NavigationFloatItem.cpp 1164052
> /trunk/KDE/kdeedu/marble/src/plugins/render/progress/ProgressFloatItem.h 1164052
> /trunk/KDE/kdeedu/marble/src/plugins/render/routing/CMakeLists.txt 1164052
> /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingInformationWidget.ui PRE-CREATION
> /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingInformationWidgetSmall.ui PRE-CREATION
> /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingItemWidget.ui 1164052
> /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.h 1164052
> /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.cpp 1164052
> /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingWidgetSmall.ui PRE-CREATION
>
> Diff: http://reviewboard.kde.org/r/5011/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> Routing Information Widget for Desktop version of marble
> http://reviewboard.kde.org/r/5011/s/478/
> Routing Widget for small screen devices. This screen shot shows the routing information widget which appears on clicking "R" on the routing widget
> http://reviewboard.kde.org/r/5011/s/479/
> navigation menu for routing widget for small screen devices
> http://reviewboard.kde.org/r/5011/s/480/
>
>
> Thanks,
>
> Siddharth
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100815/67812036/attachment-0001.htm
More information about the Marble-devel
mailing list