<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5011/">http://reviewboard.kde.org/r/5011/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 13th, 2010, 8:41 p.m., <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5011/diff/1/?file=33739#file33739line71" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">71</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">positionTrackingStatusChanged</span><span class="p">(</span> <span class="n">QString</span> <span class="n">provider</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd rather have
void positionProviderPluginChanged( PositionProviderPlugin* activePlugin )
which would be emitted by setPositionProviderPlugin(). "Disabled" would result in
emit positionProviderPluginChanged( 0 );
This avoids the redundant method.
</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">done</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 13th, 2010, 8:41 p.m., <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5011/diff/1/?file=33742#file33742line28" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/lib/graphicsview/WidgetGraphicsItem.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class QWidget;</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">28</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">class</span> <span class="n">MARBLE_EXPORT</span> <span class="n">WidgetGraphicsItem</span> <span class="o">:</span> <span class="n">public</span> <span class="n">ScreenGraphicsItem</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">28</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">class</span> <span class="n">MARBLE_EXPORT</span> <span class="n">WidgetGraphicsItem</span> <span class="o">:</span> <span class="n">public</span> <span class="k"><span class="hl">virtual</span></span><span class="hl"> </span><span class="n">ScreenGraphicsItem</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you explain this change?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">removed. Added a few weeks ago with some experimental stuff :-)</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 13th, 2010, 8:41 p.m., <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5011/diff/1/?file=33749#file33749line400" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingModel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void RoutingModel::currentInstruction( GeoDataCoordinates location, qreal speed )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">394</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">totalTimeRemaining</span> <span class="o">=</span> <span class="p">(</span> <span class="n">totalDistanceRemaining</span> <span class="o">/</span> <span class="n">speed</span> <span class="p">)</span><span class="hl"> </span><span class="o"><span class="hl">*</span></span><span class="hl"> </span><span class="n"><span class="hl">SEC2MIN</span></span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">400</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">totalTimeRemaining</span> <span class="o">=</span> <span class="p">(</span><span class="n"><span class="hl">qint64</span></span><span class="p"><span class="hl">)(</span></span> <span class="n">totalDistanceRemaining</span> <span class="o">/</span> <span class="n">speed</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Don't use c-style casts, please.
qint64 value = (qint64) something;
can be replaced with ctor-like casts:
qint64 value = qint64( something );
Then there's also qRound.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">thanks..</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 13th, 2010, 8:41 p.m., <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5011/diff/1/?file=33756#file33756line56" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">56</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">enum</span> <span class="n">CenterMode</span><span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Doesn't this enum duplicate another one?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes, similar to in AdjustNavigation</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 13th, 2010, 8:41 p.m., <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5011/diff/1/?file=33756#file33756line167" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">164</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">setRoutingItem</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">setXY without a parameter sounds odd. Maybe rename the method.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">changed to updateRoutingItem()</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 13th, 2010, 8:41 p.m., <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5011/diff/1/?file=33757#file33757line498" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void RoutingPlugin::setInstructionLabel( QLabel *label )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">479</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span> <span class="n">m_routingModel</span><span class="o">-></span><span class="n">remainingTime</span><span class="p">()</span> <span class="o"><</span> <span class="mf">3.0</span> <span class="o">&&</span> <span class="o">!</span><span class="n">m_routingModel</span><span class="o">-></span><span class="n">instructionText</span><span class="p">().</span><span class="n">isNull</span><span class="p">()</span> <span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">isEmpty()?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">oh..yes. Done</pre>
<br />
<p>- Siddharth</p>
<br />
<p>On August 15th, 2010, 6:34 p.m., Siddharth Srivastava wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble and Dennis Nienhüser.</div>
<div>By Siddharth Srivastava.</div>
<p style="color: grey;"><i>Updated 2010-08-15 18:34:41</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">An interface of Routing Plugin for Small Screen Devices is added. The Routing Plugin for Small Screen Device contains options for navigation( recenter, auto zoom), routing information widget, zoom in and zoom out functionalities.
The routing information widget for desktop version of marble, now shows the next instruction as well as the distance remaining to reach it.
The instruction point now grows in two levels when the gps location gets closer to it instead of displaying the instruction text at it. 1) The instruction point going to be visited grows in size 2) When the gps device is at certain time away from the instruction point, it grows a bit further.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.cpp <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.ui <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.cpp <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.cpp <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/graphicsview/ScreenGraphicsItem_p.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/graphicsview/WidgetGraphicsItem.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/AdjustNavigation.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/AdjustNavigation.cpp <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingLayer.cpp <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.cpp <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingModel.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingModel.cpp <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/marble.qrc <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/navigation/NavigationFloatItem.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/navigation/NavigationFloatItem.cpp <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/progress/ProgressFloatItem.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/routing/CMakeLists.txt <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingInformationWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingInformationWidgetSmall.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingItemWidget.ui <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.cpp <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingWidgetSmall.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5011/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://reviewboard.kde.org/r/5011/s/478/"><img src="http://reviewboard.kde.org/media/uploaded/images/2010/08/13/routingwidgetPCVersion_400x100.jpeg" style="border: 1px black solid;" alt="Routing Information Widget for Desktop version of marble" /></a>
<a href="http://reviewboard.kde.org/r/5011/s/479/"><img src="http://reviewboard.kde.org/media/uploaded/images/2010/08/13/routingwidgetsmall_400x100.jpeg" style="border: 1px black solid;" alt="Routing Widget for small screen devices. This screen shot shows the routing information widget which appears on clicking "R" on the routing widget" /></a>
<a href="http://reviewboard.kde.org/r/5011/s/480/"><img src="http://reviewboard.kde.org/media/uploaded/images/2010/08/13/navigationMenuroutingsmall_400x100.jpeg" style="border: 1px black solid;" alt="navigation menu for routing widget for small screen devices" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>