[Marble-devel] Review Request: Zoom via Ctrl+Mouse Selection Rectangle

[Torsten Rahn]

> On 2010-01-21 16:35:03, Dennis Nienhüser wrote:
> > Looks nice and clean code-wise, haven't tested it yet though. The new regionSelected() signal in MarbleWidget.h should get some doxygen comment.
> >
> 
> Dennis Nienhüser wrote:
>     Tested it now. Definitely a very nice addition to the input handler. It would be good to have a smaller margin though. When selecting a larger region, it even zooms out.
>     
>     I noticed one problem: When the globe does not cover the viewport, the latlonbox seems to be invalid and it moves to some default position.
>
> 
> Dennis Nienhüser wrote:
>     Still think it would be cool to have this :-)
>

Hm, I'm looking over the code and the whole use of QRubberBand is awkward. It doesn't fit the projection. I'd like to have a MarbleRubberBand which works in geodetic coordinates. I wonder however which instance would be responsible for drawing it. Should I create a plugin dedicated to drawing it? Or should it be an internal implementation inside MarbleWidget (do we want it to be accessible for MarbleMap, too)?.


- Torsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2666/#review3777
-----------------------------------------------------------


On 2010-01-21 15:45:20, Torsten Rahn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2666/
> -----------------------------------------------------------
> 
> (Updated 2010-01-21 15:45:20)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Fixes [Bug 183512] move viewport / move earth inside window
> 
> 
> This addresses bug 183512.
>     https://bugs.kde.org/show_bug.cgi?id=183512
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1077344 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.h 1077287 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp 1077287 
>   trunk/KDE/kdeedu/marble/src/marble_part.cpp 1077287 
> 
> Diff: http://reviewboard.kde.org/r/2666/diff
> 
> 
> Testing
> -------
> 
> Tested with Qt and KDE version of Marble
> 
> 
> Thanks,
> 
> Torsten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100815/edf1b149/attachment.htm