<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/2666/">http://reviewboard.kde.org/r/2666/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 21st, 2010, 4:35 p.m., <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks nice and clean code-wise, haven't tested it yet though. The new regionSelected() signal in MarbleWidget.h should get some doxygen comment.
</pre>
</blockquote>
<p>On January 21st, 2010, 11:08 p.m., <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested it now. Definitely a very nice addition to the input handler. It would be good to have a smaller margin though. When selecting a larger region, it even zooms out.
I noticed one problem: When the globe does not cover the viewport, the latlonbox seems to be invalid and it moves to some default position.
</pre>
</blockquote>
<p>On August 13th, 2010, 8:47 p.m., <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still think it would be cool to have this :-)
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm, I'm looking over the code and the whole use of QRubberBand is awkward. It doesn't fit the projection. I'd like to have a MarbleRubberBand which works in geodetic coordinates. I wonder however which instance would be responsible for drawing it. Should I create a plugin dedicated to drawing it? Or should it be an internal implementation inside MarbleWidget (do we want it to be accessible for MarbleMap, too)?.</pre>
<br />
<p>- Torsten</p>
<br />
<p>On January 21st, 2010, 3:45 p.m., Torsten Rahn wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble.</div>
<div>By Torsten Rahn.</div>
<p style="color: grey;"><i>Updated 2010-01-21 15:45:20</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes [Bug 183512] move viewport / move earth inside window</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with Qt and KDE version of Marble</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=183512">183512</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp <span style="color: grey">(1077344)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.h <span style="color: grey">(1077287)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp <span style="color: grey">(1077287)</span></li>
<li>trunk/KDE/kdeedu/marble/src/marble_part.cpp <span style="color: grey">(1077287)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/2666/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>