[Marble-devel] Review Request: Dgml Time tag handler

[hjain.itbhu at gmail.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4988/
-----------------------------------------------------------

(Updated 2010-08-14 22:35:05.683531)


Review request for marble and Bastian Holst.


Changes
-------

dateChanged() signal is added in MarbleClock class. This signal is connected to mapTexture() slot of MarbleModel. This is better approach ( date is smallest unit of QDate ) then storing all the date objects ( where the textureLayer changes ) in MarbleClock because there are then 10,000 years for which monthly themes changes.


Summary
-------

This patch merges Temperature(July) and Temperature(Dec) themes into Temperature theme by using dgml time tag. Similar, for Precipitation themes.
Kindly download the earth folder from http://uploading.com/files/5e9755bd/earth.tar.gz/ and replace it with marble/data/maps/earth folder.


Diffs (updated)
-----

  /trunk/KDE/kdeedu/marble/data/CMakeLists.txt 1162190 
  /trunk/KDE/kdeedu/marble/data/maps/earth/precip-dec/precip-dec-preview.png UNKNOWN 
  /trunk/KDE/kdeedu/marble/data/maps/earth/precip-dec/precip-dec.dgml 1162190 
  /trunk/KDE/kdeedu/marble/data/maps/earth/precip-jul/precip-jul.jpg UNKNOWN 
  /trunk/KDE/kdeedu/marble/data/maps/earth/precip/precip-preview.png UNKNOWN 
  /trunk/KDE/kdeedu/marble/data/maps/earth/precip/precip.dgml PRE-CREATION 
  /trunk/KDE/kdeedu/marble/data/maps/earth/temp-dec/temp-dec-preview.png UNKNOWN 
  /trunk/KDE/kdeedu/marble/data/maps/earth/temp-dec/temp-dec.dgml 1162190 
  /trunk/KDE/kdeedu/marble/data/maps/earth/temp-jul/temp-jul.jpg UNKNOWN 
  /trunk/KDE/kdeedu/marble/data/maps/earth/temp/temp-preview.png UNKNOWN 
  /trunk/KDE/kdeedu/marble/data/maps/earth/temp/temp.dgml PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleClock.h 1162190 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleClock.cpp 1162190 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1162190 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1162190 
  /trunk/KDE/kdeedu/marble/src/lib/StackedTileLoader.cpp 1162190 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/dgml/DgmlElementDictionary.h 1162190 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/dgml/DgmlElementDictionary.cpp 1162190 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/dgml/DgmlTimeTagHandler.h PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/dgml/DgmlTimeTagHandler.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneLayer.h 1162190 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneLayer.cpp 1162190 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneMap.h 1162190 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneMap.cpp 1162190 
  /trunk/KDE/kdeedu/marble/src/marble_part.rc 1162190 

Diff: http://reviewboard.kde.org/r/4988/diff


Testing
-------


Thanks,

hjain

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100814/b15845af/attachment.htm