<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4988/">http://reviewboard.kde.org/r/4988/</a>
     </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for marble and Bastian Holst.</div>
<div>By hjain.</div>


<p style="color: grey;"><i>Updated 2010-08-14 22:35:05.683531</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">dateChanged() signal is added in MarbleClock class. This signal is connected to mapTexture() slot of MarbleModel. This is better approach ( date is smallest unit of QDate ) then storing all the date objects ( where the textureLayer changes ) in MarbleClock because there are then 10,000 years for which monthly themes changes.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch merges Temperature(July) and Temperature(Dec) themes into Temperature theme by using dgml time tag. Similar, for Precipitation themes.
Kindly download the earth folder from http://uploading.com/files/5e9755bd/earth.tar.gz/ and replace it with marble/data/maps/earth folder.</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdeedu/marble/data/CMakeLists.txt <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/data/maps/earth/precip-dec/precip-dec-preview.png <span style="color: grey">(UNKNOWN)</span></li>

 <li>/trunk/KDE/kdeedu/marble/data/maps/earth/precip-dec/precip-dec.dgml <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/data/maps/earth/precip-jul/precip-jul.jpg <span style="color: grey">(UNKNOWN)</span></li>

 <li>/trunk/KDE/kdeedu/marble/data/maps/earth/precip/precip-preview.png <span style="color: grey">(UNKNOWN)</span></li>

 <li>/trunk/KDE/kdeedu/marble/data/maps/earth/precip/precip.dgml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/KDE/kdeedu/marble/data/maps/earth/temp-dec/temp-dec-preview.png <span style="color: grey">(UNKNOWN)</span></li>

 <li>/trunk/KDE/kdeedu/marble/data/maps/earth/temp-dec/temp-dec.dgml <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/data/maps/earth/temp-jul/temp-jul.jpg <span style="color: grey">(UNKNOWN)</span></li>

 <li>/trunk/KDE/kdeedu/marble/data/maps/earth/temp/temp-preview.png <span style="color: grey">(UNKNOWN)</span></li>

 <li>/trunk/KDE/kdeedu/marble/data/maps/earth/temp/temp.dgml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/MarbleClock.h <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/MarbleClock.cpp <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/StackedTileLoader.cpp <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/dgml/DgmlElementDictionary.h <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/dgml/DgmlElementDictionary.cpp <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/dgml/DgmlTimeTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/dgml/DgmlTimeTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneLayer.h <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneLayer.cpp <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneMap.h <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneMap.cpp <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/marble_part.rc <span style="color: grey">(1162190)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4988/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>