[Marble-devel] Review Request: Bookmark name suggestion

[1989.gaurav at gmail.com]

> On 2010-08-09 20:26:07, Dennis Nienhüser wrote:
> > trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp, line 46
> > <http://reviewboard.kde.org/r/4954/diff/2/?file=33451#file33451line46>
> >
> >     mDebug() and a bit more descriptive (or remove)

Sorry I forgot to remove this, It was just for testing purspose.
Removed


> On 2010-08-09 20:26:07, Dennis Nienhüser wrote:
> > trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp, line 63
> > <http://reviewboard.kde.org/r/4954/diff/2/?file=33451#file33451line63>
> >
> >     I'd rather have only three, but longer name suggestions:
> >     
> >     close: "road, town"
> >     medium: "town, state, country"
> >     far: "country"
> >

modified for 3 levels


> On 2010-08-09 20:26:07, Dennis Nienhüser wrote:
> > trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp, line 92
> > <http://reviewboard.kde.org/r/4954/diff/2/?file=33451#file33451line92>
> >
> >     Please also select the new text in the lineedit so that the user can easily override it

done


- 1989gaurav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4954/#review6924
-----------------------------------------------------------


On 2010-08-09 19:50:11, 1989gaurav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4954/
> -----------------------------------------------------------
> 
> (Updated 2010-08-09 19:50:11)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Added auto selection of Bookmark name and suboptimal suggestions by reverseGeocoding the coordinates.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.h 1161074 
>   trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp 1161074 
>   trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.ui 1161074 
> 
> Diff: http://reviewboard.kde.org/r/4954/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> 1989gaurav
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100810/ae501ce4/attachment-0001.htm