[Marble-devel] Review Request: Bookmark name suggestion
Dennis Nienhüser
earthwings at gentoo.org
Mon Aug 9 22:26:04 CEST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4954/#review6924
-----------------------------------------------------------
A very nice addition
trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp
<http://reviewboard.kde.org/r/4954/#comment6901>
mDebug() and a bit more descriptive (or remove)
trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp
<http://reviewboard.kde.org/r/4954/#comment6903>
I'd rather have only three, but longer name suggestions:
close: "road, town"
medium: "town, state, country"
far: "country"
trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp
<http://reviewboard.kde.org/r/4954/#comment6904>
Please also select the new text in the lineedit so that the user can easily override it
- Dennis
On 2010-08-09 19:50:11, 1989gaurav wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4954/
> -----------------------------------------------------------
>
> (Updated 2010-08-09 19:50:11)
>
>
> Review request for marble.
>
>
> Summary
> -------
>
> Added auto selection of Bookmark name and suboptimal suggestions by reverseGeocoding the coordinates.
>
>
> Diffs
> -----
>
> trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.h 1161074
> trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp 1161074
> trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.ui 1161074
>
> Diff: http://reviewboard.kde.org/r/4954/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> 1989gaurav
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100809/99b7c6b6/attachment.htm
More information about the Marble-devel
mailing list