[Marble-devel] Review Request: Code cleanup: Move some static methods from TileLoaderHelper directly to GeoSceneTexture and use TileId as parameter.

[jensmh at gmx.de]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3588/#review5330
-----------------------------------------------------------

Ship it!


looks good imho


trunk/KDE/kdeedu/marble/src/lib/ServerLayout.h
<http://reviewboard.kde.org/r/3588/#comment5014>

    MARBLE_SERVERLAYOUT_H



trunk/KDE/kdeedu/marble/src/lib/ServerLayout.h
<http://reviewboard.kde.org/r/3588/#comment5015>

    opening braces for namespaces should be on their own line



trunk/KDE/kdeedu/marble/src/lib/ServerLayout.h
<http://reviewboard.kde.org/r/3588/#comment5016>

    constructors which accept one argument should be declared explicit



trunk/KDE/kdeedu/marble/src/lib/ServerLayout.h
<http://reviewboard.kde.org/r/3588/#comment5017>

    explicit, perhaps OsmServerLayout?



trunk/KDE/kdeedu/marble/src/lib/ServerLayout.h
<http://reviewboard.kde.org/r/3588/#comment5018>

    a parameter name for the QUrl parameter would not hurt here as it is not entirely obvious


- jmho


On 2010-04-30 10:36:41, Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3588/
> -----------------------------------------------------------
> 
> (Updated 2010-04-30 10:36:41)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> This patch represents milestone 1 of a series of patches to add more (server-side) storage layouts. In this series of patches, an abstract base class will be used to create download URLs, allowing for easy addition of server-side storage layouts. See [1] for all patches.
> 
> [1] http://github.com/shentok/marble/commits/custom-storage
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1121091 
>   trunk/KDE/kdeedu/marble/src/lib/ServerLayout.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/ServerLayout.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/StackedTileLoader.cpp 1121091 
>   trunk/KDE/kdeedu/marble/src/lib/TileLoader.cpp 1121091 
>   trunk/KDE/kdeedu/marble/src/lib/TileLoaderHelper.h 1121091 
>   trunk/KDE/kdeedu/marble/src/lib/TileLoaderHelper.cpp 1121091 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/dgml/DgmlStorageLayoutTagHandler.cpp 1121091 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.h 1121091 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.cpp 1121091 
>   trunk/KDE/kdeedu/marble/src/tilecreator/CMakeLists.txt 1121091 
> 
> Diff: http://reviewboard.kde.org/r/3588/diff
> 
> 
> Testing
> -------
> 
> Works for me, please test.
> 
> 
> Thanks,
> 
> Bernhard
> 
>