[Marble-devel] Review Request: Code cleanup: Move some static methods from TileLoaderHelper directly to GeoSceneTexture and use TileId as parameter.

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3588/
-----------------------------------------------------------

(Updated 2010-04-30 10:36:41.544496)


Review request for marble.


Changes
-------

New patch including bug fix for bluemarble theme plus ServerLayout class.


Summary (updated)
-------

This patch represents milestone 1 of a series of patches to add more (server-side) storage layouts. In this series of patches, an abstract base class will be used to create download URLs, allowing for easy addition of server-side storage layouts. See [1] for all patches.

[1] http://github.com/shentok/marble/commits/custom-storage


Diffs (updated)
-----

  trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1121091 
  trunk/KDE/kdeedu/marble/src/lib/ServerLayout.h PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/ServerLayout.cpp PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/StackedTileLoader.cpp 1121091 
  trunk/KDE/kdeedu/marble/src/lib/TileLoader.cpp 1121091 
  trunk/KDE/kdeedu/marble/src/lib/TileLoaderHelper.h 1121091 
  trunk/KDE/kdeedu/marble/src/lib/TileLoaderHelper.cpp 1121091 
  trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/dgml/DgmlStorageLayoutTagHandler.cpp 1121091 
  trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.h 1121091 
  trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.cpp 1121091 
  trunk/KDE/kdeedu/marble/src/tilecreator/CMakeLists.txt 1121091 

Diff: http://reviewboard.kde.org/r/3588/diff


Testing
-------

Works for me, please test.


Thanks,

Bernhard