[Marble-devel] Review Request: Add "Download Region" feature

[jensmh at gmx.de]

> On 2010-04-24 08:34:01, Michael Hansen wrote:
> > /trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.cpp, line 166
> > <http://reviewboard.kde.org/r/3797/diff/1/?file=24424#file24424line166>
> >
> >     There is no title set for the dialog yet.

Fixed


> On 2010-04-24 08:34:01, Michael Hansen wrote:
> > /trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.cpp, line 91
> > <http://reviewboard.kde.org/r/3797/diff/1/?file=24424#file24424line91>
> >
> >     Maybe call it "Current view", like in printing dialogs.

It's "visible region" now, to be consistent with "Download region".


> On 2010-04-24 08:34:01, Michael Hansen wrote:
> > /trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.cpp, line 39
> > <http://reviewboard.kde.org/r/3797/diff/1/?file=24424#file24424line39>
> >
> >     The "Ok" button is just disabled when I go over this limit - maybe a short notice for the user that we are above the limit.

Fixed, a message box is now shown when the limit is exceeded.


- jmho


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3797/#review5200
-----------------------------------------------------------


On 2010-04-24 04:35:27, jmho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3797/
> -----------------------------------------------------------
> 
> (Updated 2010-04-24 04:35:27)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> This patch adds the missing bits (mostly UI related) for "Download region".
> The .ui are based on those kindly provided by Torsten Rahn.
> 
> Remaining issues:
> 1) the tile level range widget is not shown correctly in the download region dialog
> 2) UI hangs for some time while the download queue is being filled
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/AbstractScanlineTextureMapper.h 1118235 
>   /trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1118235 
>   /trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/LatLonBoxWidget.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/LatLonBoxWidget.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/LatLonBoxWidget.ui PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1118235 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1118235 
>   /trunk/KDE/kdeedu/marble/src/lib/TileCoordsPyramid.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/TileCoordsPyramid.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/TileLevelRangeWidget.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/TileLevelRangeWidget.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/TileLevelRangeWidget.ui PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/marble_part.h 1118235 
>   /trunk/KDE/kdeedu/marble/src/marble_part.cpp 1118235 
>   /trunk/KDE/kdeedu/marble/src/marble_part.rc 1118235 
> 
> Diff: http://reviewboard.kde.org/r/3797/diff
> 
> 
> Testing
> -------
> 
> - several tests with "current region" as selection method => works minus above issues
> - one test with specified lat/lon box => seems to work
> 
> 
> Thanks,
> 
> jmho
> 
>