[Marble-devel] Review Request: Add "Download Region" feature

[Michael Hansen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3797/#review5200
-----------------------------------------------------------


For applications using Marble, it would be nice to have the dialog available from the right click context menu as well, then the user does not have to launch the standalone Marble version to download the tiles.


/trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.cpp
<http://reviewboard.kde.org/r/3797/#comment4701>

    The "Ok" button is just disabled when I go over this limit - maybe a short notice for the user that we are above the limit.



/trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.cpp
<http://reviewboard.kde.org/r/3797/#comment4700>

    Maybe call it "Current view", like in printing dialogs.



/trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.cpp
<http://reviewboard.kde.org/r/3797/#comment4702>

    There is no title set for the dialog yet.


- Michael


On 2010-04-24 04:35:27, jmho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3797/
> -----------------------------------------------------------
> 
> (Updated 2010-04-24 04:35:27)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> This patch adds the missing bits (mostly UI related) for "Download region".
> The .ui are based on those kindly provided by Torsten Rahn.
> 
> Remaining issues:
> 1) the tile level range widget is not shown correctly in the download region dialog
> 2) UI hangs for some time while the download queue is being filled
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/AbstractScanlineTextureMapper.h 1118235 
>   /trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1118235 
>   /trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/LatLonBoxWidget.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/LatLonBoxWidget.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/LatLonBoxWidget.ui PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1118235 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1118235 
>   /trunk/KDE/kdeedu/marble/src/lib/TileCoordsPyramid.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/TileCoordsPyramid.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/TileLevelRangeWidget.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/TileLevelRangeWidget.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/TileLevelRangeWidget.ui PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/marble_part.h 1118235 
>   /trunk/KDE/kdeedu/marble/src/marble_part.cpp 1118235 
>   /trunk/KDE/kdeedu/marble/src/marble_part.rc 1118235 
> 
> Diff: http://reviewboard.kde.org/r/3797/diff
> 
> 
> Testing
> -------
> 
> - several tests with "current region" as selection method => works minus above issues
> - one test with specified lat/lon box => seems to work
> 
> 
> Thanks,
> 
> jmho
> 
>