[Marble-devel] Review Request: Code cleanup: Move some static methods from TileLoaderHelper directly to GeoSceneTexture and use TileId as parameter.

[Bastian Holst]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3588/#review5012
-----------------------------------------------------------


To me, it looks good apart from the little issues I marked in the source code. I'll test it soon (now ;)).


trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.h
<http://reviewboard.kde.org/r/3588/#comment4507>

    This comment doesn't seem very reasonable here now.



trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.h
<http://reviewboard.kde.org/r/3588/#comment4508>

    I wonder if we should leave a “simple” getter here as we had before.



trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.h
<http://reviewboard.kde.org/r/3588/#comment4506>

    Documentation missing, please add it!



trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.h
<http://reviewboard.kde.org/r/3588/#comment4505>

    Please add the documentation here.
    Perhaps we should change the function name to “themeString” so we don't have an abbreviation here.


- Bastian


On 2010-04-13 14:59:45, Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3588/
> -----------------------------------------------------------
> 
> (Updated 2010-04-13 14:59:45)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> This patch represents milestone 1 of a series of patches to add more (server-side) storage layouts. In this series of patches, the GeoSceneTexture::StorageLayoutMode enum will be replaced by an abstract class, allowing for easy addition of server-side storage layouts. See [1] for all patches.
> 
> [1] http://github.com/shentok/marble/commits/custom-storage
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/StackedTileLoader.cpp 1114412 
>   trunk/KDE/kdeedu/marble/src/lib/TileLoader.cpp 1114412 
>   trunk/KDE/kdeedu/marble/src/lib/TileLoaderHelper.h 1114412 
>   trunk/KDE/kdeedu/marble/src/lib/TileLoaderHelper.cpp 1114412 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.h 1114412 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.cpp 1114412 
> 
> Diff: http://reviewboard.kde.org/r/3588/diff
> 
> 
> Testing
> -------
> 
> Works for me, please test.
> 
> 
> Thanks,
> 
> Bernhard
> 
>