[Marble-devel] Review Request: Code cleanup: Move some static methods from TileLoaderHelper directly to GeoSceneTexture and use TileId as parameter.

Bernhard Beschow bbeschow at cs.tu-berlin.de
Tue Apr 13 16:59:45 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3588/
-----------------------------------------------------------

Review request for marble.


Summary
-------

This patch represents milestone 1 of a series of patches to add more (server-side) storage layouts. In this series of patches, the GeoSceneTexture::StorageLayoutMode enum will be replaced by an abstract class, allowing for easy addition of server-side storage layouts. See [1] for all patches.

[1] http://github.com/shentok/marble/commits/custom-storage


Diffs
-----

  trunk/KDE/kdeedu/marble/src/lib/StackedTileLoader.cpp 1114412 
  trunk/KDE/kdeedu/marble/src/lib/TileLoader.cpp 1114412 
  trunk/KDE/kdeedu/marble/src/lib/TileLoaderHelper.h 1114412 
  trunk/KDE/kdeedu/marble/src/lib/TileLoaderHelper.cpp 1114412 
  trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.h 1114412 
  trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.cpp 1114412 

Diff: http://reviewboard.kde.org/r/3588/diff


Testing
-------

Works for me, please test.


Thanks,

Bernhard



More information about the Marble-devel mailing list