[Marble-devel] My first patch

[Torsten Rahn]

Hi Simon,

I fully agree on the more descriptive command line option and description.

Maybe someone can come up with a suggestion for a short option name that makes 
it also clear that the tile id appears on the map (a short one please! so we 
don't end up with  "marble --showTileIdOnTheMap")

Regards,

Torsten

On Thursday 19 March 2009 20:37:42 Simon Schmeißer wrote:
> Hi Harshit, Hi Torsten,
>
> maybe it should be something more like "--displayTileIds" for consitency
> and to improve understandability. Also the descriptive text could contain
> some additional information. Maybe something like "Shows the internal tile
> ids on the map for debugging"
>
> and there's two newlines missing before and after the new function :
> --- trunk/KDE/kdeedu/marble/src/lib/MarbleMap.cpp #941487:941488
> @@ -994,7 +994,13 @@
>          d->m_model->update();
>      }
>  }
> +void MarbleMap::setShowTileId( bool visible )
> +{
>
> +    d->m_model->layerDecorator()->setShowTileId( visible );
> +
> +
> +}
>  void MarbleMap::setShowGrid( bool visible )
>  {
>
>
> Otherwise, nice job Harshit :-)
>
> cu Simon
>
> Am Donnerstag, 19. März 2009 19:05:27 schrieb harshit jain:
> > Hi,
> >    I have done a junior job of giving command line option to show tile-id
> > in marble. Command line option is for function :- void
> > MergedLayerDecorator::setShowTileId(bool show);     which is inside the
> > file
> >
> > :- marble/src/lib/MergedLayerDecorator.cpp
> >
> >    Patch for this is attached with mail.
> >
> >    Suggest me improvements could be done in this patch.
>
> _______________________________________________
> Marble-devel mailing list
> Marble-devel at kde.org
> https://mail.kde.org/mailman/listinfo/marble-devel