[Marble-devel] another sorting problem; slow map changing

[Mülner, Helmut]

________________________________________
Von: Torsten Rahn [rahn at kde.org]
Gesendet: Freitag, 12. Juni 2009 14:34
An: marble-devel at kde.org
Cc: Mülner, Helmut
Betreff: Re: [Marble-devel] another sorting problem; slow map changing

Hi Helmut,

 > Are you working on trunk or branch currently?

I work on trunk an use qt-4.5.1 with Windows (qt-only).

>> sorting by popularityIndex is done too early:
>> m_popSortModel->sort( 0, Qt::DescendingOrder ); in the constructor of
>> MarbleModel does not sort anything, and
>> d->m_popSortModel->setDynamicSortFilter( true ); is commented out (I guess
>> because it is too slow).

> Yes, we just don't sort dynamically due to speed concerns.

I thought so.

>> This has the effect that painting is not done correctly because
>> m_popSortModel is not sorted.

> Hm, it does get sorted properly here as far as I can judge from the visual
> result  -- I know there are problems with Marble 0.7 in combination with Qt
> 4.5 though.

It looked okay for me also, but then I missed some big cities and looked for the reason.

I did not find any code that calls m_popSortModel->sort(..) after loading is finished.

>> In my local version I have added the call to sort in
>> MarbleModelPrivate::notifyModelChanged(), but I fear this is called too
>> often. Any ideas?

> I'm not too familiar with the code without looking at it so I can't give an
> immediate reply on this question. Maybe Patrick has got some thoughts?

>> The following comment in MarbleModel::setMapTheme:
>> does not agree with the code, which always unloads all old containers and
>> then load all new containers. This results in a very slow map change.

> Maybe Patrick can  shed some light on this?

I debugged the code and found some confusion between container names ("cityplacemarks") and file names
("cityplacemarks.kml"). My changes are attached as a patch.

Best regards,

Helmut
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MarbleModel-patch
Type: application/octet-stream
Size: 805 bytes
Desc: MarbleModel-patch
Url : http://mail.kde.org/pipermail/marble-devel/attachments/20090612/4a9de9da/attachment.dll