[Marble-devel] Review Request: move file storage from FileViewModel to PlacemarkManager

[tgridel at free.fr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1379/
-----------------------------------------------------------

Review request for marble.


Summary
-------

- moving the QList of AbstractFileViewItems into PlacemarkManager
- simplifying access to name in AbstractFileViewItems while removing modelish data()
- PlacemarkManager signals files added/removed for fileViewModel to stay up to date
- fileViewModel holds its selection model, which views should use

I have tried and stay minimal in changes.
It will soon be possible to separate placemark handling from pure file handling


Diffs
-----

  /trunk/KDE/kdeedu/marble/src/lib/AbstractFileViewItem.h 1013814 
  /trunk/KDE/kdeedu/marble/src/lib/FileViewModel.h 1013814 
  /trunk/KDE/kdeedu/marble/src/lib/FileViewModel.cpp 1013814 
  /trunk/KDE/kdeedu/marble/src/lib/GpxFileViewItem.h 1013814 
  /trunk/KDE/kdeedu/marble/src/lib/GpxFileViewItem.cpp 1013814 
  /trunk/KDE/kdeedu/marble/src/lib/KmlFileViewItem.h 1013814 
  /trunk/KDE/kdeedu/marble/src/lib/KmlFileViewItem.cpp 1013814 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.cpp 1013814 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1013814 
  /trunk/KDE/kdeedu/marble/src/lib/PlacemarkManager.h 1013814 
  /trunk/KDE/kdeedu/marble/src/lib/PlacemarkManager.cpp 1013814 

Diff: http://reviewboard.kde.org/r/1379/diff


Testing
-------

the fileView works with regards file display (checkbox) and file close.
Placemark List gets updated.


Thanks,

tgridel