[Marble-devel] Review Request: Provide Models through the MarbleDataFacade

[tgridel at free.fr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1287/
-----------------------------------------------------------

Review request for marble.


Summary
-------

This patch is the first step in a simplification of model handling.

It just refactors code, pushing all models into the MarbleDataFacade.
(and clarifying ownership issues with all those getters for models).
This also provides all models in an easy way for e.g. plugins now.

My ideas then are to 
- separate the file loading within PlacemarkManager from the management of placemarks per se.
  This means that the filling of the PlacemarkModel will be done in PlacemarkManager, while
  the current PlacemarkLoader threading would be used for file reading. (The cache binary format
  could then be used for other parsings maybe)
- support the file formats of GeoDataParser to use the parser only there.
- provide the result of those parsing to models in MarbleDataFacade (like now).
- work on a proper solution to use the graphicsitems with those models.

Ideas and comments welcome!


Diffs
-----

  /trunk/KDE/kdeedu/marble/src/lib/MarbleDataFacade.h 1010153 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleDataFacade.cpp 1010153 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1010153 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1010153 
  /trunk/KDE/kdeedu/marble/src/lib/MarblePlacemarkModel.h 1010153 
  /trunk/KDE/kdeedu/marble/src/lib/MarblePlacemarkModel.cpp 1010153 
  /trunk/KDE/kdeedu/marble/src/lib/PlacemarkManager.h 1010153 
  /trunk/KDE/kdeedu/marble/src/lib/PlacemarkManager.cpp 1010153 
  /trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererPlugin.cpp 1010153 

Diff: http://reviewboard.kde.org/r/1287/diff


Testing
-------


Thanks,

tgridel