[Marble-devel] Review Request: Add a function to the Marble Widget to simplify the process of getting Geo Coordinates

Torsten Rahn rahn at kde.org
Tue Aug 11 17:13:49 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1264/#review1975
-----------------------------------------------------------


I have my problems with this kind of method: geoCoordinates takes a Coordinate object as a storage for the result. However this calculation can only work if you assume a certain altitude in advance. In this way this is not very symmetrical to screenCoordinates, where the altitude would get taken into account.

- Torsten


On 2009-08-11 12:44:35, Andrew Manson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1264/
> -----------------------------------------------------------
> 
> (Updated 2009-08-11 12:44:35)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Just a convenience function to simplify getting GeoDataCoordinates from screen coordinates from the Marble widget. 
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.h 1009962 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp 1009962 
> 
> Diff: http://reviewboard.kde.org/r/1264/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew
> 
>



More information about the Marble-devel mailing list