[Marble-devel] Review Request: Threadsafe HttpDownloadManager

Henry de Valence hdevalence at gmail.com
Tue Aug 11 07:10:41 CEST 2009



> On 2009-08-10 20:34:19, jmho_ wrote:
> > Looks good in principle, however
> > 
> > 1) imho there is a lock in removeJob missing,
> > 2) I'm not sure if it is sufficient to have locks only in public methods
> > 
> > thanks

With regard to #2, if private methods are called from public methods, then the mutex is already locked by the time they are called. But if they are called from somewhere else (not sure where this would be) then there could be problems. 

I'll look into #1.


- Henry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1235/#review1966
-----------------------------------------------------------


On 2009-08-07 00:01:07, Henry de Valence wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1235/
> -----------------------------------------------------------
> 
> (Updated 2009-08-07 00:01:07)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Adds threadsafety to the HttpDownloadManager using a QMutex.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/HttpDownloadManager.h 1008141 
>   trunk/KDE/kdeedu/marble/src/lib/HttpDownloadManager.cpp 1008141 
> 
> Diff: http://reviewboard.kde.org/r/1235/diff
> 
> 
> Testing
> -------
> 
> Tested using the downloader to pull OSM tiles but didn't test from another thread, because I'm not sure how to go about doing that yet. I have some changes to the MarbleRunners that will require it, but they're not done yet.
> 
> 
> Thanks,
> 
> Henry
> 
>



More information about the Marble-devel mailing list