[Marble-devel] Review Request: Threadsafe HttpDownloadManager

[jensmh at gmx.de]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1235/#review1966
-----------------------------------------------------------


Looks good in principle, however

1) imho there is a lock in removeJob missing,
2) I'm not sure if it is sufficient to have locks only in public methods

thanks

- jmho_


On 2009-08-07 00:01:07, Henry de Valence wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1235/
> -----------------------------------------------------------
> 
> (Updated 2009-08-07 00:01:07)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Adds threadsafety to the HttpDownloadManager using a QMutex.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/HttpDownloadManager.h 1008141 
>   trunk/KDE/kdeedu/marble/src/lib/HttpDownloadManager.cpp 1008141 
> 
> Diff: http://reviewboard.kde.org/r/1235/diff
> 
> 
> Testing
> -------
> 
> Tested using the downloader to pull OSM tiles but didn't test from another thread, because I'm not sure how to go about doing that yet. I have some changes to the MarbleRunners that will require it, but they're not done yet.
> 
> 
> Thanks,
> 
> Henry
> 
>