[Marble-devel] [Patch] fix marble data dirs on win32

[Torsten Rahn]

On Saturday 03 November 2007 17:35:40 you wrote:
> Torsten Rahn schrieb:
> > Unfortunately this is not a viable solution as this would change the
> > libmarble binary to get compiled against KDE.
> >
> > Please find a different solution that doesn't require anything in
> > marble/src/lib to have a KDE dependency (even an #ifdef'd one).
>
> You should have told me earlier :)
>
> Here a new patch.

That looks good to me :-) If nobody else objects, please apply.

I only now realized that in the CMakeLists.txt file I should also remove the 
#if (QTONLY) clause that distinguishes the linking (because there don't get 
any kde classes used in the library). I'll do that later today.

> I've also removed two QDir::separator() because they're useless as long
> as you don't want to show them the user (Qt internally only use '/')

Ok, to me it looks cleaner using QDir::seperator() because the reader gets the 
idea that it's not limited to Unix. Therefore I favour the QDir::separator() 
notation.

Torsten 

>
> Christian



-- 
 Torsten Rahn

 Tel.: 0 21 61 - 46 43 - 192

credativ GmbH, HRB Mönchengladbach 12080
Hohenzollernstr. 133, 41061 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz