[Marble-bugs] [Bug 274558] Marble crashes on exit if MarbleRunners are still active

Dennis Nienhüser earthwings at gentoo.org
Fri Jan 20 22:30:37 UTC 2012


https://bugs.kde.org/show_bug.cgi?id=274558





--- Comment #6 from Dennis Nienhüser <earthwings gentoo org>  2012-01-20 22:30:37 ---
Git commit b6d75a4e70bea2bf0313453f5d83b30a5f52deb9 by Dennis Nienhüser.
Committed on 18/01/2012 at 20:37.
Pushed by nienhueser into branch 'Touch/1.3'.

Do not delete plugin instances. Fixes segfaults with multiple widgets.
(cherry picked from commit 8f5d08a5d4dd8a78536327bd73ac170303655790)
Related: bug 288542
FIXED-IN: KDE-4.8.0

M  +5    -21   src/lib/PluginManager.cpp
M  +2    -0    src/plugins/runner/monav/MonavPlugin.cpp
M  +2    -0    src/plugins/runner/monav/MonavPlugin.h

http://commits.kde.org/marble/b6d75a4e70bea2bf0313453f5d83b30a5f52deb9

--- Comment #7 from Dennis Nienhüser <earthwings gentoo org>  2012-01-20 22:30:37 ---
Git commit 1246d4e04dbdba4b4a3b6c00f2c105d79794c4b7 by Dennis Nienhüser.
Committed on 31/12/2011 at 10:55.
Pushed by nienhueser into branch 'Touch/1.3'.

Do not unload plugins in PluginManager dtor.

According to qt documentation this is not needed. Not unloading plugins
avoids timing issues at destruction time: Plugin related instances can
be deleted after the deletion of MarbleModel now. Previously
MarbleModel deleted the PluginManager, which unloaded the plugins and
then created dangling pointers for plugin related instances not cleaned
up at that time.

Should be backported to the KDE/4.8 branch after testing.
Related: bug 288542
(cherry picked from commit 4a1af05a822894d77bacac0932df6d38e74bcc10)

M  +20   -31   src/lib/PluginManager.cpp

http://commits.kde.org/marble/1246d4e04dbdba4b4a3b6c00f2c105d79794c4b7

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the Marble-bugs mailing list