Potential kxstitch/qt5 5.11 issue

[Sean Enck]

On Sun, Jun 3, 2018 at 6:46 AM, Steve Allewell <steve.allewell at gmail.com>
wrote:

> On 02/06/18 20:51, Sean Enck wrote:
> > Running archlinux, recently qt5 5.11 has dropped (from 5.10), I went to
> > rebuild kxstitch in a clean environment and hit the following
> >
> > https://gist.githubusercontent.com/enckse/1490da81a531937d093c0ec826caf3
> f5/raw/826f324b9943e77b002bdb4f36b25b85a46cc92d/gistfile1.txt
> >
> > I'm assuming this is a qt5 5.11 (potentially incorrectly), I can provide
> > more of a log if needed and/or more information.
>
> I suspect this is because LibraryPatternPropertiesDlg does not include
> the QIcon header directly, relying on it being included in one of the
> other ones.
>
> Can you try adding into LibraryPatternPropertiesDlg.h the following line
> under class QShowEvent:
>
> class QIcon;
>
> and in LibraryPatternPropertiesDlg.cpp under #include <KSharedConfig>:
>
> #include <QIcon>
>
> Then try recompiling.  I think there might be similar errors perhaps.
> My distribution is usually quick to update these packages, so I will
> probably be on 5.11 soon so I will be able to test for myself.
>
> Thanks
>
> Steve
>

OK, that worked, though I did have to make an additional change in
TextElementDialog.{h,cpp}.

The whole of the patch is still short:
https://gist.github.com/enckse/5032964a9f0f135618709752f1dd4235

It builds now - thanks for the help!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kxstitch/attachments/20180603/70b3cbe1/attachment.html>