D25339: update lineHeight if boundingRect indicates a larger value.
noreply at phabricator.kde.org
Sat May 9 15:16:16 BST 2020
cullmann added a comment.
In D25339#666877 <https://phabricator.kde.org/D25339#666877>, @rjvbb wrote:
> > Looking at the code, might it make more sense to just move away from the fixed height we have?
> > It isn't used that often and in most cases one could just query the height of the current line.
> I'd be all for that, provided it doesn't introduce any regressions in the rendered result nor in rendering time.
> It could be trickier to implement than you think though?
It is a non-trivial change.
But I think any other change, like this, will lead to issues, too, and is just a "hack".
I have taken a closer look.
I assume the lineHeight usages in the renderer are easy to replace with the proper "height()" of the individual lines of the layout.
Harder to replace is the use of the lineHeight outside of the renderer.
To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb
Cc: ahmadsamir, brauch, sars, pshinjo, rjvbb, fakefred, anthonyfieroni, kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel