D25339: update lineHeight if boundingRect indicates a larger value.
René J.V. Bertin
noreply at phabricator.kde.org
Sat May 9 13:06:39 BST 2020
rjvbb added a comment.
> Looking at the code, might it make more sense to just move away from the fixed height we have?
> It isn't used that often and in most cases one could just query the height of the current line.
I'd be all for that, provided it doesn't introduce any regressions in the rendered result nor in rendering time.
It could be trickier to implement than you think though?
To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb
Cc: ahmadsamir, brauch, sars, pshinjo, rjvbb, fakefred, anthonyfieroni, kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel