D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

René J.V. Bertin noreply at phabricator.kde.org
Mon May 4 21:37:48 BST 2020

rjvbb added a comment.

  This patch is only needed when mixing a main Latin1 (like) alphanumeric font with occasional glyphs from a font that have a different, taller height?
  Am I right that any text that uses only a single font will see some form of significant loss of the number of lines that fit within a given vertical space?
  >   Test 3 - Ubuntu Mono + Noto Sans Mono CJK KR 9pt. For me the right hand side is a regression, since neither Cyrillic nor Korean scripts are clearly visible when both of them are in the same line. Also in this setup most of Korean texts are cut by half even when there are only Korean texts. Compare it with the other lines where only Cyrillic is visible:...
  > But this part is the raison d'etre for this patch: provide enough font height for non-latin-1 text. Also not considered is glyphs from other scripts, such as Cyrillic, Arabic, ... What could be another solution?
  If local lineheight adaptation isn't possible with the current implementation (not even by inserting 1 or more virtual linebreaks?) then the behaviour introduced with this patch c/should become optional. Selected automatically if possible (with an off toggle in the settings dialog) but otherwise via a menu action that's not too well hidden so people who need to turn it on and off on any kind of regular basis can do so without having to hunt the command down too much.

  R39 KTextEditor


To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb
Cc: pshinjo, rjvbb, fakefred, anthonyfieroni, kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20200504/76148265/attachment-0001.html>

More information about the KWrite-Devel mailing list