D26620: Do not assume that list of documents is non-empty

Thomas Friedrichsmeier noreply at phabricator.kde.org
Mon Jan 13 11:00:01 GMT 2020


tfry created this revision.
tfry added a reviewer: cullmann.
Herald added a project: Kate.
Herald added a subscriber: kwrite-devel.
tfry requested review of this revision.

REVISION SUMMARY
  Host applications may not always have an active view, and a non-empty list of documents. This would currently crash when clicking the "Search"-button with "Current File" or "Open Files".

TEST PLAN
  Tested with plugin loaded in RKWard, and no documents present. Segfault without patch, no matches, with patch.

REPOSITORY
  R40 Kate

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26620

AFFECTED FILES
  addons/search/plugin_search.cpp
  addons/search/search_open_files.cpp

To: tfry, cullmann
Cc: kwrite-devel, rrosch, domson, michaelh, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20200113/9a8652b7/attachment-0001.html>


More information about the KWrite-Devel mailing list