D27180: Add sortable columns to session manager dialog, and remove previous sorting code

[Dominik Haumann]

dhaumann added a comment.


  I'd be fine with committing this. Still, there very clearly is large room to improve this further.

INLINE COMMENTS

> katesessionchooseritem.h:38
>          setText(1, docs);
> +        setText(2, s->timestamp().toString(QString::fromStdString("yyyy-MM-dd  hh:mm:ss")));
>      }

I believe that seconds are a bit over engineered. In fact, it would be nice to do the sorting based on the timestamp as now, but visually the English format does not fit very well in other languages. So this should be translated via i18n. But then we loose the correct sorting.

So for now this patch is ok, but in the long run we should do better.

For instance, I think it would be much more user friendly to have "Yesterday", "3 days ago", ... instead of the datetime right now.

Would you be interested to look into this as well?

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D27180

To: rrosch, #kate, dhaumann, cullmann
Cc: kwrite-devel, rrosch, domson, michaelh, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20200206/8ad222a0/attachment.html>