D21401: Use native dialog overwrite check
noreply at phabricator.kde.org
Sun May 26 07:46:35 BST 2019
meven added a comment.
In D21401#470121 <https://phabricator.kde.org/D21401#470121>, @ngraham wrote:
> This will work fine for a KDE environment where we know that the file dialog correctly handles the overwrite use case. Do we know that the GTK file dialog does the same for when Kate is run on GNOME, XFCE, or MATE?
I believe it will be fine. https://developer.gnome.org/gtk3/stable/GtkFileChooserDialog.html GtkFileChooserDialog has a `gtk_file_chooser_set_do_overwrite_confirmation` (since 2005's gtk 2.8) so I would expect QFileDialog to use this feature.
So given GNOME, XFCE and MATE uses gtk >= 2.8, I don't foresee an issue on those DE.
Also bug https://bugreports.qt.io/browse/QTBUG-11539 mentions it works under GNOME at least.
On the QFileDialog side, I wish it would be better documented : https://doc.qt.io/archives/qt-4.8/qfiledialog.html#details mentioned GNOME and KDE but not anymore in qt5 stable documentation https://doc.qt.io/qt-5/qfiledialog.html#details
To: meven, ngraham, #frameworks, #kate, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel