<table><tr><td style="">meven added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21401">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D21401#470121" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D21401#470121</a>, <a href="https://phabricator.kde.org/p/ngraham/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ngraham</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>This will work fine for a KDE environment where we know that the file dialog correctly handles the overwrite use case. Do we know that the GTK file dialog does the same for when Kate is run on GNOME, XFCE, or MATE?</p></div>
</blockquote>
<p>I believe it will be fine. <a href="https://developer.gnome.org/gtk3/stable/GtkFileChooserDialog.html" class="remarkup-link" target="_blank" rel="noreferrer">https://developer.gnome.org/gtk3/stable/GtkFileChooserDialog.html</a> GtkFileChooserDialog has a <tt style="background: #ebebeb; font-size: 13px;">gtk_file_chooser_set_do_overwrite_confirmation</tt> (since 2005's gtk 2.8) so I would expect QFileDialog to use this feature.<br />
So given GNOME, XFCE and MATE uses gtk >= 2.8, I don't foresee an issue on those DE.<br />
Also bug <a href="https://bugreports.qt.io/browse/QTBUG-11539" class="remarkup-link" target="_blank" rel="noreferrer">https://bugreports.qt.io/browse/QTBUG-11539</a> mentions it works under GNOME at least.</p>
<p>On the QFileDialog side, I wish it would be better documented : <a href="https://doc.qt.io/archives/qt-4.8/qfiledialog.html#details" class="remarkup-link" target="_blank" rel="noreferrer">https://doc.qt.io/archives/qt-4.8/qfiledialog.html#details</a> mentioned GNOME and KDE but not anymore in qt5 stable documentation <a href="https://doc.qt.io/qt-5/qfiledialog.html#details" class="remarkup-link" target="_blank" rel="noreferrer">https://doc.qt.io/qt-5/qfiledialog.html#details</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R39 KTextEditor</div></div></div><br /><div><strong>BRANCH</strong><div><div>native-overwrite-check</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21401">https://phabricator.kde.org/D21401</a></div></div><br /><div><strong>To: </strong>meven, ngraham, Frameworks, Kate, cullmann<br /><strong>Cc: </strong>cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann<br /></div>