D20958: New menu of syntax highlighting in the status bar

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> katemodemenulist.cpp:65
> +    m_list->setVerticalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
> +    m_list->setIconSize(QSize(16, 16));
> +    m_list->setResizeMode(QListView::Adjust);

As well for icon size.

> katemodemenulist.cpp:129
> +     */
> +    const int maxWidthText = m_list->sizeHint().width() - m_scroll->sizeHint().width() - 28;
> +

You can make a static const int iconSize = 16 or something to use it everywhere?

> katemodemenulist.cpp:141
> +        if ( !hl->translatedSection.isEmpty() && (prevHlSection == nullptr || hl->translatedSection != *prevHlSection) ) {
> +            QPixmap transparent = QPixmap(8, 8);
> +            transparent.fill(Qt::transparent);

Here as well, if it's 16/2

> katemodemenulist.cpp:266
> +    if (m_selectedItem) {
> +        QPixmap emptyIcon(16, 16);
> +        emptyIcon.fill(Qt::transparent);

Ditto

> katemodemenulist.cpp:407
> +    // set empty icon
> +    QPixmap emptyIcon(16, 16);
> +    emptyIcon.fill(Qt::transparent);

Ditto

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20958

To: nibags, #ktexteditor, #kate, #vdg
Cc: anthonyfieroni, cullmann, ngraham, loh.tar, kwrite-devel, kde-frameworks-devel, domson, michaelh, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190503/ec73cb35/attachment-0001.html>