D20958: New menu of syntax highlighting in the status bar
noreply at phabricator.kde.org
Fri May 3 12:46:02 BST 2019
nibags added a comment.
Thanks for the comments, in a while I will update the diff with the suggestions/corrections.
> The only thing I would like to have is an auto generated "most often used" list. That was also suggested somewhere. This way you could quickly change between preferred styles instead to search for them.
I could add a "Recent" section to the beginning of the menu, it would be useful.
> When the menu is opened, clear any text in the search field left over from a prior search
Also I could keep all the search text as selected, to delete it with a single button.
I hope more comments about it, I'm not sure which will be the best option: S
> Single-clicking on an item in the list should select it and close the menu; double-click doesn't gain us anything here
To me the double-click works correctly. It may also be necessary to add a special case for double-click to avoid problems.
> .cp does not show c++, same for cp
I checked the XML file of "C++", and `*.cp` isn't an extension associated with that language, so it isn't displayed.
> These ctrl-return is handy! Would be good to have this on right or middle too or in conjunction with some modifier key alt/ctrl/shift
Good idea! I will also add shift and alt and combinations.
> The blue frame (in dark theme) looks compared to the other plain menus slightly strange, any possibility to remove this?
You can erase the edge, but I'm not sure if the brightness. I will try, although I don't know if it will be a good idea, since that brightness indicates that the widget is in focus.
As @ngraham says, it might be better to reduce the brightness in the Breeze Dark theme.
> Is your new great menu easy usable for other parts? Like the encoding?
It could be done. I would have to separate the menu into two classes that are inherited, one with the menu only, so that it can be implemented elsewhere.
> As first feedback: much better than current state :)
To: nibags, #ktexteditor, #kate, #vdg
Cc: cullmann, ngraham, loh.tar, kwrite-devel, kde-frameworks-devel, domson, michaelh, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel