D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[René J.V. Bertin]

rjvbb added a comment.


  >   I would rather keep the current behavior and let people use sane fonts if the want unicode.
  
  That's not current acceptable IMHO, not with the cumbersome way of selecting the font.
  
  If proper document display depends on "user picking a sane font", they should have a drop-down list where they can pick one quickly, and with a clear and easy way to make this a temporary or a document-specific choice.
  
  Also, while it's clear that you cannot expect everything to work properly with any font, accepting that the user just has to pick the right font to avoid lineheight issues is a slippery slope that I'd fear could easily lead to hardwiring a limited selection of typefaces just to avoid bug reports. That would be fine (AFAIAC) for Kate, but not for the framework that provides the editor component for more complex applications like KDevelop.
  
  Rather, an effort should be made to implement support for variable lineheights (GSoC? junior job?)
  
  > how should the user set it to the "right value" if it can differ per line?
  
  The same way they can pick a "sane font"? FWIW, I'm using Ubuntu Mono, that's supposed to be pretty complete and should be sane too.
  
  The "right value" here would be a value that works for all lines = the tallest lineheight that gives proper line separation everywhere. My guess would be that you will already catch most situations with a choice of 1.5x and 2x .
  
  > And I don't see a benefit in supporting that at all
  
  There are situations where I would welcome the possibility to increase line spacing on the fly, for improved readability - I'm certain I'm not the only one.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190302/183b82b9/attachment.html>