D22067: Don't clear the session KConfing object too early

Ahmad Samir noreply at phabricator.kde.org
Mon Jun 24 21:12:51 BST 2019

ahmadsamir added a comment.

  In D22067#486282 <https://phabricator.kde.org/D22067#486282>, @cullmann wrote:
  > Taking a look at the code, I think one can not just keep that pointer/group around that long.
  > One could try to e.g. remember the keys with values for positions in finishRestore() and use that as overwrite in createToolView like we do there with
  >   // try the restore config to figure out real pos
  >   if (m_restoreConfig && m_restoreConfig->hasGroup(m_restoreGroup)) {
  >       KConfigGroup cg(m_restoreConfig, m_restoreGroup);
  >       pos = (KMultiTabBar::KMultiTabBarPosition) cg.readEntry(QStringLiteral("Kate-MDI-ToolView-%1-Position").arg(identifier), int(pos));
  >   }
  > As long as the config pointer is valid, no operation showing/moving toolviews will have any effect.
  Yep, there must have been a good reason why those two variables were cleared at the end of finishRestore(); I should have looked closer for that reason; I'll rework the diff. (Sorry about the noise).

  R40 Kate


To: ahmadsamir, #kate, cullmann, dhaumann
Cc: kwrite-devel, domson, michaelh, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190624/92435a65/attachment.html>

More information about the KWrite-Devel mailing list