D21876: When loading a session always restore the open recent list

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Kate, cullmann.
Herald added a project: Kate.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Previously the code in loadSession only called KateMainWindow::readProperties
  if "restore window configuration" was true, but readProperties has
  nothing, AFAICS, to do with the window configuration. This also fixes
  a bug where kate didn't load the open recent files entries if
  "restore window configuration" was set to false.
  
  BUG: 408499
  FIXED-IN: 19.08.0

TEST PLAN
  - Open a kate window and load a session
  - Make sure "restore window configuration" is enabled on the session config page
  - Open some files so that there are some entries in File -> Open Recent
  - Save the session, then close and reopen it, the entries in Open Recent should be displayed as expected
  - Disable "restore window configuration", then save the session, close it then reopen it, note that the Open Recent menu is disabled/grayed
  - Apply the patch then try again, and Open Recent entries should be restored as expected

REPOSITORY
  R40 Kate

BRANCH
  session-window-configuration (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21876

AFFECTED FILES
  kate/session/katesessionmanager.cpp

To: ahmadsamir, #kate, cullmann
Cc: kwrite-devel, domson, michaelh, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190617/601529db/attachment.html>