<table><tr><td style="">ahmadsamir created this revision.<br />ahmadsamir added reviewers: Kate, cullmann.<br />Herald added a project: Kate.<br />ahmadsamir requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21876">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Previously the code in loadSession only called KateMainWindow::readProperties<br />
if "restore window configuration" was true, but readProperties has<br />
nothing, AFAICS, to do with the window configuration. This also fixes<br />
a bug where kate didn't load the open recent files entries if<br />
"restore window configuration" was set to false.</p>
<p>BUG: 408499<br />
FIXED-IN: 19.08.0</p></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">Open a kate window and load a session</li>
<li class="remarkup-list-item">Make sure "restore window configuration" is enabled on the session config page</li>
<li class="remarkup-list-item">Open some files so that there are some entries in File -> Open Recent</li>
<li class="remarkup-list-item">Save the session, then close and reopen it, the entries in Open Recent should be displayed as expected</li>
<li class="remarkup-list-item">Disable "restore window configuration", then save the session, close it then reopen it, note that the Open Recent menu is disabled/grayed</li>
<li class="remarkup-list-item">Apply the patch then try again, and Open Recent entries should be restored as expected</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R40 Kate</div></div></div><br /><div><strong>BRANCH</strong><div><div>session-window-configuration (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21876">https://phabricator.kde.org/D21876</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kate/session/katesessionmanager.cpp</div></div></div><br /><div><strong>To: </strong>ahmadsamir, Kate, cullmann<br /><strong>Cc: </strong>kwrite-devel, domson, michaelh, ngraham, demsking, cullmann, sars, dhaumann<br /></div>