D22479: Prompt user to save or discard changes

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> kateconfigdialog.cpp:427
> +    const auto response = KMessageBox::warningYesNoCancel(this,
> +                                        i18n("You have have unsaved changes. Do you want to apply the changes or discard them?"),
> +                                        i18n("Warning"),

Typo: have have

> kateconfigdialog.cpp:435
> +            slotApply();
> +            Q_FALLTHROUGH();
> +        case KMessageBox::No:

I'd prefer to repeat event->accept + break here, instead of using fallthrough.

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D22479

To: shubham, cullmann, ngraham
Cc: dhaumann, kwrite-devel, univerz, domson, michaelh, ngraham, demsking, cullmann, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190726/c3c15560/attachment.html>