D22500: Make keyword completion model return HideListIfAutomaticInvocation by default

Ahmad Samir noreply at phabricator.kde.org
Tue Jul 16 23:24:01 BST 2019


ahmadsamir created this revision.
ahmadsamir added reviewers: KTextEditor, KDevelop, cullmann, dhaumann, brauch.
Herald added projects: Kate, Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Change KateKeywordCompletionModel::matchingItem to return
  HideListIfAutomaticInvocation so that the completions menu is hidden for
  typed keywords, e.g. typing "return" the menu get auto hidden.

TEST PLAN
  - Enable keyword completion in kate
  - Open a file and change the mode to a language where return is a keyword say C++
  - Type "return", check that when the word is fully typed the completions menu is hidden

REPOSITORY
  R39 KTextEditor

BRANCH
  ahmad/keyword-auto-completion (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22500

AFFECTED FILES
  src/completion/katekeywordcompletion.cpp

To: ahmadsamir, #ktexteditor, #kdevelop, cullmann, dhaumann, brauch
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, sbergeron, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190716/cedd7c80/attachment.html>


More information about the KWrite-Devel mailing list