D22721: Clean up Kate addons CMake scripts.

Andreas Sturmlechner noreply at phabricator.kde.org
Wed Jul 24 19:38:44 BST 2019


asturmlechner added inline comments.

INLINE COMMENTS

> daandemeyer wrote in CMakeLists.txt:1
> Doesn't the KF5 find module take care of that? I found this comment in its documentation:
> 
> > If all the required components (those given in the COMPONENTS argument, but not those given in the OPTIONAL_COMPONENTS argument) are found, ``KF5_FOUND``will be set to true. Otherwise, it will be set to false.

Yes, it seems to work fine now that I tried. It may have been a bug with an older cmake version.

REVISION DETAIL
  https://phabricator.kde.org/D22721

To: daandemeyer, #kate
Cc: turbov, asturmlechner, kwrite-devel, domson, michaelh, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190724/2959773d/attachment-0001.html>


More information about the KWrite-Devel mailing list