D22721: Clean up Kate addons CMake scripts.

Daan De Meyer noreply at phabricator.kde.org
Wed Jul 24 18:32:24 BST 2019


daandemeyer added inline comments.

INLINE COMMENTS

> asturmlechner wrote in CMakeLists.txt:1
> It would be a good opportunity to keep them sorted.
> 
> For maintainer to decide: Although I rather have optional dependencies be found all separately as it does not lead to `KF5` be set to not found if one of them is being disabled or not found (and other packages had build failures caused by that).

Doesn't the KF5 find module take care of that? I found this comment in its documentation:

> If all the required components (those given in the COMPONENTS argument, but not those given in the OPTIONAL_COMPONENTS argument) are found, ``KF5_FOUND``will be set to true. Otherwise, it will be set to false.

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D22721

To: daandemeyer, #kate
Cc: asturmlechner, kwrite-devel, domson, michaelh, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190724/a5cac628/attachment-0001.html>


More information about the KWrite-Devel mailing list