christoph at cullmann.io
Wed Jul 24 07:28:02 BST 2019
On 2019-07-24 00:10, Daan De Meyer wrote:
> Also as a follow-up question, I moved the two defines from kate's
> config.h into the CMake scripts using `target_compile_definitions` and
> the only thing left in it is the version. Does that mean the config.h
> file can be removed or is there code that depends on the version
> defined in the config.h file?
don't think 3.1 should be a problem. config.h is Not required elsewhere
> On Tue, 23 Jul 2019 at 23:55, Daan De Meyer <daan.j.demeyer at gmail.com>
>> I've almost finished a pretty big cleanup of all the CMake files
>> including addons. I standardized everything on 2 spaces.
>> Should I just make a single revision on Phabricator or try to split
>> it up into multiple revisions?
>> I also upped the minimum CMake version to 3.1 (from 3.0) to have
>> access to `target_sources`
>> Is that a problem?
>> On Tue, 23 Jul 2019 at 22:08, Christoph Cullmann
>> <christoph at cullmann.io> wrote:
>>> On 2019-07-23 18:04, Daan De Meyer wrote:
>>>> I'm cleaning up the CMake scripts a little and was wondering
>>>> style to use. Generally, CMake projects (outside of KDE) tend to
>>> use 2
>>>> space indentation but I'm seeing both 2 and 4 spaces indentation
>>>> the CMake files (and see the .kateconfig specifying 4 spaces).
>>>> there a guideline I should follow here?
>>> Think we are flexible, would keep 2 spaces, if
>>> our files are that already.
>>> Ignorance is bliss...
>>> https://cullmann.io | https://kate-editor.org
Ignorance is bliss...
https://cullmann.io | https://kate-editor.org
More information about the KWrite-Devel