CMake style

[Daan De Meyer]

Also as a follow-up question, I moved the two defines from kate's config.h
into the CMake scripts using `target_compile_definitions` and the only
thing left in it is the version. Does that mean the config.h file can be
removed or is there code that depends on the version defined in the
config.h file?

Regards,

Daan


On Tue, 23 Jul 2019 at 23:55, Daan De Meyer <daan.j.demeyer at gmail.com>
wrote:

> I've almost finished a pretty big cleanup of all the CMake files including
> addons. I standardized everything on 2 spaces.
>
> Should I just make a single revision on Phabricator or try to split it up
> into multiple revisions?
>
> I also upped the minimum CMake version to 3.1 (from 3.0) to have access to
> `target_sources` (
> https://cmake.org/cmake/help/latest/command/target_sources.html).  Is
> that a problem?
>
> Regards,
>
> Daan
>
> On Tue, 23 Jul 2019 at 22:08, Christoph Cullmann <christoph at cullmann.io>
> wrote:
>
>> On 2019-07-23 18:04, Daan De Meyer wrote:
>> > Hi,
>> >
>> > I'm cleaning up the CMake scripts a little and was wondering what
>> > style to use. Generally, CMake projects (outside of KDE) tend to use 2
>> > space indentation but I'm seeing both 2 and 4 spaces indentation in
>> > the CMake files (and see the .kateconfig specifying 4 spaces). Is
>> > there a guideline I should follow here?
>> >
>> > Regards,
>> >
>> > Daan
>> Hi,
>>
>> Think we are flexible, would keep 2 spaces, if
>> our files are that already.
>>
>> Greetings
>> Christoph
>>
>> --
>> Ignorance is bliss...
>> https://cullmann.io | https://kate-editor.org
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190724/acde2b59/attachment.html>