D17971: Revive External Tools plugin

[Dominik Haumann]

dhaumann updated this revision to Diff 50143.
dhaumann added a comment.


  - Remove ExternalToolRunner, was already factored out
  - Create KateToolRunner on the heap to not block Kate
  - Run clang-format
  - Fix comment
  - Factor out KateExternalToolsConfigWidget into separate file
  - Rename externaltools -> m_externalToolsMenu and make it private
  - Use signal&slot to trigger reload of a menu
  - Delete messy extView() helper function, not needed anymore
  - Add API documentation and remove m_view variable
  - Cleanup includes
  - Delete support for separators. Support for categories will be added later

REPOSITORY
  R40 Kate

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17971?vs=50028&id=50143

BRANCH
  revive-externaltools-plugin

REVISION DETAIL
  https://phabricator.kde.org/D17971

AFFECTED FILES
  addons/CMakeLists.txt
  addons/externaltools/CMakeLists.txt
  addons/externaltools/Messages.sh
  addons/externaltools/autotests/CMakeLists.txt
  addons/externaltools/autotests/externaltooltest.cpp
  addons/externaltools/autotests/externaltooltest.h
  addons/externaltools/configwidget.ui
  addons/externaltools/externaltools
  addons/externaltools/externaltools.cpp
  addons/externaltools/externaltools.h
  addons/externaltools/externaltoolsplugin.cpp
  addons/externaltools/externaltoolsplugin.desktop
  addons/externaltools/externaltoolsplugin.h
  addons/externaltools/kateexternaltool.cpp
  addons/externaltools/kateexternaltool.h
  addons/externaltools/kateexternaltoolscommand.cpp
  addons/externaltools/kateexternaltoolscommand.h
  addons/externaltools/kateexternaltoolsconfigwidget.cpp
  addons/externaltools/kateexternaltoolsconfigwidget.h
  addons/externaltools/katemacroexpander.cpp
  addons/externaltools/katemacroexpander.h
  addons/externaltools/katetoolrunner.cpp
  addons/externaltools/katetoolrunner.h
  addons/externaltools/plugin.qrc
  addons/externaltools/tooldialog.ui
  addons/externaltools/ui.rc

To: dhaumann, cullmann, gregormi
Cc: brauch, pino, ngraham, kwrite-devel, hase, michaelh, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190123/f5b96c13/attachment-0001.html>