D17971: Revive External Tools plugin

[Dominik Haumann]

dhaumann updated this revision to Diff 50028.
dhaumann added a comment.


  - Factor out KateExternalToolsCommand into separate file
  - Revive KTextEditor::Command interface by moving tool execution to KateExternalToolsPlugin
  - Pass plugin pointer to actions, since the plugin will act as model
  - Plugin: save Tool pointers, since these stable pointers will be reused by the actions
  - KateExternalToolMenuAction: Use tools from plugin
  - Remove KateExternalToolAction in favor of simply using QAction with QAction::data()
  - Minor cleanups

REPOSITORY
  R40 Kate

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17971?vs=49972&id=50028

BRANCH
  revive-externaltools-plugin

REVISION DETAIL
  https://phabricator.kde.org/D17971

AFFECTED FILES
  addons/CMakeLists.txt
  addons/externaltools/CMakeLists.txt
  addons/externaltools/Messages.sh
  addons/externaltools/autotests/CMakeLists.txt
  addons/externaltools/autotests/externaltooltest.cpp
  addons/externaltools/autotests/externaltooltest.h
  addons/externaltools/configwidget.ui
  addons/externaltools/externaltools
  addons/externaltools/externaltools.cpp
  addons/externaltools/externaltools.h
  addons/externaltools/externaltoolsplugin.cpp
  addons/externaltools/externaltoolsplugin.desktop
  addons/externaltools/externaltoolsplugin.h
  addons/externaltools/kateexternaltool.cpp
  addons/externaltools/kateexternaltool.h
  addons/externaltools/kateexternaltoolscommand.cpp
  addons/externaltools/kateexternaltoolscommand.h
  addons/externaltools/katemacroexpander.cpp
  addons/externaltools/katemacroexpander.h
  addons/externaltools/katetoolrunner.cpp
  addons/externaltools/katetoolrunner.h
  addons/externaltools/plugin.qrc
  addons/externaltools/tooldialog.ui
  addons/externaltools/ui.rc

To: dhaumann, cullmann, gregormi
Cc: brauch, pino, ngraham, kwrite-devel, hase, michaelh, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190121/74ca88f2/attachment-0001.html>