D17308: Make CTags/Projects context menu more accessible

Kåre Särs noreply at phabricator.kde.org
Sun Jan 13 10:38:20 GMT 2019

sars accepted this revision.
sars added a comment.
This revision is now accepted and ready to land.

  I'm not entirely sure removing the feature of having the lookup word in the menu is an improvement, but I just noticed that the feature is broken and only works when a word is selected.
  If you think this is an improvement (with that one string fixed), I'm ok with this going in. I still mostly just use the shortcuts :)


> kate_ctags_view.cpp:66
>      QAction *lookup = actionCollection()->addAction(QLatin1String("ctags_lookup_current"));
> -    lookup->setText(i18n("Lookup Current Text"));
> +    lookup->setText(i18n("Look up Selected Text"));
>      connect(lookup, &QAction::triggered, this, &KateCTagsView::lookupTag);

This change is not entirely correct as you do not need to select any text. You can look up the word containing the text cursor. That is why it says "current" and not "selected" text.

I would suggest "Look Up Current Text"

  R40 Kate



To: gregormi, #kate, sars
Cc: dhaumann, sars, ngraham, kwrite-devel, hase, michaelh, demsking, cullmann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190113/bccf95e2/attachment.html>

More information about the KWrite-Devel mailing list