<table><tr><td style="">sars accepted this revision.<br />sars added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17308">View Revision</a></tr></table><br /><div><div><p>I'm not entirely sure removing the feature of having the lookup word in the menu is an improvement, but I just noticed that the feature is broken and only works when a word is selected.</p>

<p>If you think this is an improvement (with that one string fixed), I'm ok with this going in. I still mostly just use the shortcuts :)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17308#inline-100545">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kate_ctags_view.cpp:66</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QAction</span> <span style="color: #aa2211">*</span><span class="n">lookup</span> <span style="color: #aa2211">=</span> <span class="n">actionCollection</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">addAction</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"ctags_lookup_current"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">lookup</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Look<span class="bright">up Current</span> Text"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">lookup</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Look<span class="bright"> up Selected</span> Text"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">connect</span><span class="p">(</span><span class="n">lookup</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">QAction</span><span style="color: #aa2211">::</span><span class="n">triggered</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">KateCTagsView</span><span style="color: #aa2211">::</span><span class="n">lookupTag</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This change is not entirely correct as you do not need to select any text. You can look up the word containing the text cursor. That is why it says "current" and not "selected" text.</p>

<p style="padding: 0; margin: 8px;">I would suggest "Look Up Current Text"</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R40 Kate</div></div></div><br /><div><strong>BRANCH</strong><div><div>arcpatch-D17308</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17308">https://phabricator.kde.org/D17308</a></div></div><br /><div><strong>To: </strong>gregormi, Kate, sars<br /><strong>Cc: </strong>dhaumann, sars, ngraham, kwrite-devel, hase, michaelh, demsking, cullmann<br /></div>