D17443: Kate: Keyboard shortcuts F6/Shift+F6 for Next/Previous Match

[gregormi]

gregormi added a comment.


  In D17443#379785 <https://phabricator.kde.org/D17443#379785>, @gregormi wrote:
  
  > In D17443#379221 <https://phabricator.kde.org/D17443#379221>, @dhaumann wrote:
  >
  > > Could you serch for Key_F6 in the KTextEditor and Kate source code? I want to avoid that we overlook something.
  >
  >
  > I'll report back.
  
  
  Relevant occurrences of F6 in Kate source code:
  
  - menus.docbook and fundamentals.docbook (for view-show-icon-border which is removed by https://phabricator.kde.org/D17442)
  
  Relevant occurrences of F6 in KTextEditor source code:
  
  - Qt::Key_F6 for view-border (which is removed by https://phabricator.kde.org/D17442)
  
  So, no problem there. Ready from my side.

INLINE COMMENTS

> kateviewmanager.cpp:179
>      goPrev->setText(i18n("Previous Split View"));
> -    m_mainWindow->actionCollection()->setDefaultShortcut(goPrev, Qt::SHIFT + Qt::Key_F8);
> +    m_mainWindow->actionCollection()->setDefaultShortcuts(goPrev, { Qt::SHIFT + Qt::Key_F8, Qt::CTRL + Qt::SHIFT + Qt::Key_P });
>      connect(goPrev, SIGNAL(triggered()), this, SLOT(activatePrevView()));

todo: Remove F8

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D17443

To: gregormi, #kate
Cc: dhaumann, kwrite-devel, hase, michaelh, ngraham, demsking, cullmann, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190112/1c3dddae/attachment.html>