<table><tr><td style="">gregormi added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17443">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D17443#379785" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D17443#379785</a>, <a href="https://phabricator.kde.org/p/gregormi/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@gregormi</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D17443#379221" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D17443#379221</a>, <a href="https://phabricator.kde.org/p/dhaumann/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dhaumann</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Could you serch for Key_F6 in the KTextEditor and Kate source code? I want to avoid that we overlook something.</p></div>
</blockquote>
<p>I'll report back.</p></div>
</blockquote>
<p>Relevant occurrences of F6 in Kate source code:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">menus.docbook and fundamentals.docbook (for view-show-icon-border which is removed by <a href="https://phabricator.kde.org/D17442" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D17442</a>)</li>
</ul>
<p>Relevant occurrences of F6 in KTextEditor source code:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Qt::Key_F6 for view-border (which is removed by <a href="https://phabricator.kde.org/D17442" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D17442</a>)</li>
</ul>
<p>So, no problem there. Ready from my side.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17443#inline-100517">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kateviewmanager.cpp:179</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">goPrev</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Previous Split View"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">m_mainWindow</span><span style="color: #aa2211">-></span><span class="n">actionCollection</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">setDefaultShortcut</span><span class="p">(</span><span class="n">goPrev</span><span class="p">,</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">SHIFT</span> <span style="color: #aa2211">+</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">Key_F8</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_mainWindow</span><span style="color: #aa2211">-></span><span class="n">actionCollection</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">setDefaultShortcut<span class="bright">s</span></span><span class="p">(</span><span class="n">goPrev</span><span class="p">,</span> <span class="bright"></span><span class="p"><span class="bright">{</span></span><span class="bright"> </span><span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">SHIFT</span> <span style="color: #aa2211">+</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">Key_F8<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">Qt</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">CTRL</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="n"><span class="bright">Qt</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">SHIFT</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="n"><span class="bright">Qt</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">Key_P</span></span><span class="bright"> </span><span class="p"><span class="bright">}</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">connect</span><span class="p">(</span><span class="n">goPrev</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">triggered</span><span class="p">()),</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">activatePrevView</span><span class="p">()));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">todo: Remove F8</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R40 Kate</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17443">https://phabricator.kde.org/D17443</a></div></div><br /><div><strong>To: </strong>gregormi, Kate<br /><strong>Cc: </strong>dhaumann, kwrite-devel, hase, michaelh, ngraham, demsking, cullmann, sars<br /></div>