D19367: [RFC]SearchBar: Don't block GUI when enter incremental pattern

[loh tar]

loh.tar updated this revision to Diff 52728.
loh.tar edited the summary of this revision.
loh.tar set the repository for this revision to R39 KTextEditor.
loh.tar added a comment.


  - Don't trigger onIncPatternChanged when update search history
  - Only save search history on some change
  
  One nice issue found, but the test is still failing.
  But I think that's a problem of the test. The values are compared while the search has not finished.
  Unfortunately would the test finish fine when we exclude the above mentioned special case under "(No)Issues" :-/ But I think that's only a hint that not all cases tested.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19367?vs=52669&id=52728

REVISION DETAIL
  https://phabricator.kde.org/D19367

AFFECTED FILES
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190227/ff20086f/attachment.html>